Short loop.run_in_executor with asyncio.to_thread#820
Merged
Conversation
Doesn't require: - finding the loop as it uses the default; - passing "None" as executor as it uses the default; - using partial to pass kwargs
Although Python doesn't support canceling coroutines in a different thread, it allows gathering the result. QMemMan also doesn't allow canceling API calls, so the cancel is a no-op.
Contributor
Author
|
PipelineRetryFailed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
==========================================
- Coverage 70.42% 70.29% -0.13%
==========================================
Files 61 61
Lines 14143 14138 -5
==========================================
- Hits 9960 9939 -21
- Misses 4183 4199 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
PipelineRetry |
This was referenced Jun 6, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026060617-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests22 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 22 fixed
Unstable testsDetails
Performance TestsPerformance degradation:20 performance degradations
Remaining performance tests:91 tests
|
This was referenced Jun 6, 2026
Add disk2 status and update volume retrieval method
QubesOS/qubes-desktop-linux-i3-settings-qubes#23
Open
marmarek
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't require:
Didn't test at all, but would be nice to use a shorter version, since we are not using the full capabilities of the executor, a wrapper is easier to read. If you look atasyncio/threads.py, it's just callingloop.run_in_executor.Edit: tested manually the preloaded disposable early request before qmemman finishes and watching the logs. Didn't run integration tests, and that would be appropriate for the different files I changed.